Code review comment for lp://qastaging/~verzegnassi-stefano/ubuntu-docviewer-app/document-hub2

Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

A few comments.

* Really like that documents just appear when I copy them into ~/Documents. Also like that deleting them removes them from disk. This helps with managing disk space! Nice one!

* If we only look in ~/Documents then it doesn't find files on my SD card which are in /media/phablet/2541-1C26/Documents - and as we no longer have the "+" button in the toolbar, I can't add them to the list using file manager.

* Long press to delete brings buttons in the toolbar which are not right-aligned. There is a gap (I assume where the list/grid toggle button was) in the toolbar. I think the buttons should appear on the right. http://people.canonical.com/~alan/screenshots/device-2015-02-28-155804.png

* Long press to delete is not easily discovered and doesn't match the rest of the platform which uses swipe right to delete (see music / contacts / alarms etc). Can we have long press for multi-select delete _and_ swipe right for single document delete?

« Back to merge proposal