Code review comment for lp://qastaging/~verzegnassi-stefano/ubuntu-docviewer-app/document-hub2

Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

> A few comments.
>
> * Really like that documents just appear when I copy them into ~/Documents.
> Also like that deleting them removes them from disk. This helps with managing
> disk space! Nice one!

Glad you like it!

> * If we only look in ~/Documents then it doesn't find files on my SD card
> which are in /media/phablet/2541-1C26/Documents - and as we no longer have the
> "+" button in the toolbar, I can't add them to the list using file manager.

Well, you can open files from the file manager itself: Document Viewer will be shown in the list of the available destinations for the trasfer, and a local copy will be created in ~/Documents.
ATM I prefer not to support external storages, since this MP is already huge for testing, and I still need to find out the best solution for being notified of changes in the list of removable medias.

> * Long press to delete brings buttons in the toolbar which are not right-
> aligned. There is a gap (I assume where the list/grid toggle button was) in
> the toolbar. I think the buttons should appear on the right.
> http://people.canonical.com/~alan/screenshots/device-2015-02-28-155804.png

I saw it some time ago. It seemed to me that it was unpredictable, and doesn't happen any time the headerState switches.
Sure I'll try to fix it.

> * Long press to delete is not easily discovered and doesn't match the rest of
> the platform which uses swipe right to delete (see music / contacts / alarms
> etc). Can we have long press for multi-select delete _and_ swipe right for
> single document delete?

Design reasons. I've already added a comment in the code in order to remember that I have to activate the swipe-to-delete gesture.
Sure we can have it, but I need to find equivalent action for the delegate in the grid view mode.
I'm open to any suggestions. :)

« Back to merge proposal