Code review comment for lp://qastaging/~verzegnassi-stefano/ubuntu-docviewer-app/document-hub2

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

There is a problem with file importing.
You do a check to check if already exists a file with the same name. If there is, then you import the file adding a numb at the end of the name.

if(QFile::exists(destination))

But I think you should add another check: if the new file it's the same you already imported, then don't import it.

I think the best way to achieve this check is to use md5 function.

http://doc.qt.io/qt-5/qml-qtqml-qt.html#md5-method

« Back to merge proposal