Merge lp://qastaging/~victor-mireyev/simple-scan/483393 into lp://qastaging/~simple-scan-team/simple-scan/trunk

Proposed by Victor Mireyev
Status: Superseded
Proposed branch: lp://qastaging/~victor-mireyev/simple-scan/483393
Merge into: lp://qastaging/~simple-scan-team/simple-scan/trunk
Diff against target: 162 lines (+103/-22)
2 files modified
src/book-view.vala (+5/-0)
src/ui.vala (+98/-22)
To merge this branch: bzr merge lp://qastaging/~victor-mireyev/simple-scan/483393
Reviewer Review Type Date Requested Status
Robert Ancell Needs Fixing
Review via email: mp+107669@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2012-06-01.

Description of the change

Allow drag and drop of pages to external programs.

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

I'm trying this patch and it doesn't do anything for me - I can see the drag and drop icon but no application seems to take the image (tried gimp, gedit, thunderbird).

It crashes when I try and drag to the desktop:
(simple-scan:5448): GLib-ERROR **: /build/buildd/glib2.0-2.33.1/./glib/gmem.c:195: failed to allocate 9223372036854775807 bytes

review: Needs Fixing
582. By Victor Mireyev

Limit maximum URI length. Support drag-drop to Gimp.

583. By Victor Mireyev

Drop support for XdndDirectSave0 protocol.
Add support for uri targets.

Revision history for this message
Victor Mireyev (victor-mireyev) wrote :

I have tested my patch with Shotwell, desktop, Nautilus and Gimp.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches