Simple Scan

Merge lp://qastaging/~victor-mireyev/simple-scan/483393 into lp://qastaging/~simple-scan-team/simple-scan/trunk

483393
Merge into trunk

Proposed by Victor Mireyev on 2012-06-01

Status:

Merged

Merged at revision:

583

Proposed branch:

lp://qastaging/~victor-mireyev/simple-scan/483393

Merge into:

lp://qastaging/~simple-scan-team/simple-scan/trunk

Diff against target:

162 lines (+103/-22)

2 files modified

src/book-view.vala (+5/-0)
src/ui.vala (+98/-22)

To merge this branch:

bzr merge lp://qastaging/~victor-mireyev/simple-scan/483393

Wishlist

Triaged

Link a bug report

Reviewer	Review Type	Date Requested	Status
Robert Ancell		2012-06-01	Approve on 2012-06-06
Review via email: mp+108289@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2012-05-28.

Description of the change

Allow drag and drop of pages to external programs.

Revision history for this message

Robert Ancell (robert-ancell) wrote on 2012-05-28: Posted in a previous version of this proposal

I'm trying this patch and it doesn't do anything for me - I can see the drag and drop icon but no application seems to take the image (tried gimp, gedit, thunderbird).

It crashes when I try and drag to the desktop:
(simple-scan:5448): GLib-ERROR **: /build/buildd/glib2.0-2.33.1/./glib/gmem.c:195: failed to allocate 9223372036854775807 bytes

review: Needs Fixing

Revision history for this message

Victor Mireyev (victor-mireyev) wrote on 2012-05-30: Posted in a previous version of this proposal

I have tested my patch with Shotwell, desktop, Nautilus and Gimp.

Revision history for this message

Robert Ancell (robert-ancell) wrote on 2012-06-06:

Great! Works perfectly for me now.

review: Approve

Revision history for this message

Michael Nagel (nailor) wrote on 2012-08-05:

This introduced a regression, please see https://bugs.launchpad.net/simple-scan/+bug/1033162