Ubuntu CI Services

Merge lp://qastaging/~vila/ubuntu-ci-services-itself/tr-more-tests into lp://qastaging/ubuntu-ci-services-itself

  1. tr-more-tests
  2. Merge into trunk
Proposed by Vincent Ladeuil
Status: Merged
Approved by: Evan
Approved revision: 357
Merged at revision: 363
Proposed branch: lp://qastaging/~vila/ubuntu-ci-services-itself/tr-more-tests
Merge into: lp://qastaging/ubuntu-ci-services-itself
Diff against target: 90 lines (+22/-13)
3 files modified
test_runner/run_test.py (+17/-10)
test_runner/tstrun/testbed.py (+3/-2)
tests/test_runner/test.py (+2/-1)
To merge this branch: bzr merge lp://qastaging/~vila/ubuntu-ci-services-itself/tr-more-tests
Reviewer Review Type Date Requested Status
Evan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+210456@code.qastaging.launchpad.net

Commit message

Fix bad support for multiple packages testing.

Description of the change

This fixes two bugs in the run_test.py script used by the test bed:

1) The '.dsc' file was broken, the selection rule was too strict,

2) It failed early when testing the second (or third package)

Another issue outline here is that the test runner should produce more logs,
but there are bugs already filed (bug #1287256 and bug #1288529) for that
and I'll address them separately.

Using PYTHONPATH=`pwd`/test_runner:$PYTHONPATH ./test_runner/tstrun/testbed.py proved useful again (too bad it's broken for hp currently bug #1288622).

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:357
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/376/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/376/rebuild

review: Approve (continuous-integration)
Revision history for this message
Evan (ev) wrote :

+ run('mkdir', '-p', 'results')

+ run('mkdir', package)

What's the point of creating a subprocess for these? Is it to get the stderr output captured in the ticket if they fail? Otherwise, why not use os.mkdir and os.makedirs?

Otherwise this looks good. +1

review: Approve
Revision history for this message
Evan (ev) wrote :

Top approving too.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches