Code review comment for lp://qastaging/~vila/ubuntu-ci-services-itself/tr-more-tests

Revision history for this message
Evan (ev) wrote :

+ run('mkdir', '-p', 'results')

+ run('mkdir', package)

What's the point of creating a subprocess for these? Is it to get the stderr output captured in the ticket if they fail? Otherwise, why not use os.mkdir and os.makedirs?

Otherwise this looks good. +1

review: Approve

« Back to merge proposal