OpenStack Compute (nova)

Merge lp://qastaging/~vishvananda/nova/fix-floating-reboot into lp://qastaging/~hudson-openstack/nova/trunk

  1. fix-floating-reboot
  2. Merge into trunk
Proposed by Vish Ishaya
Status: Merged
Approved by: Devin Carlen
Approved revision: 1542
Merged at revision: 1571
Proposed branch: lp://qastaging/~vishvananda/nova/fix-floating-reboot
Merge into: lp://qastaging/~hudson-openstack/nova/trunk
Diff against target: 97 lines (+14/-6)
4 files modified
nova/db/api.py (+5/-3)
nova/db/sqlalchemy/api.py (+4/-1)
nova/network/manager.py (+2/-1)
nova/tests/db/fakes.py (+3/-1)
To merge this branch: bzr merge lp://qastaging/~vishvananda/nova/fix-floating-reboot
Reviewer Review Type Date Requested Status
Devin Carlen (community) Approve
Dan Prince (community) Approve
Review via email: mp+75279@code.qastaging.launchpad.net

Description of the change

Fix issue where floating ips don't get recreated when a network host reboots.

To post a comment you must log in.
Revision history for this message
Dan Prince (dan-prince) wrote :

This looks good. I suppose we could attempt to populate the host columns via a DB migration (by looking in the services table for a network host?). Kind of a polish thing but if a user had lots of floating IPs it could save a bit of time.

I think this is good though.

review: Approve
Revision history for this message
Devin Carlen (devcamcar) wrote :

lgtm

Vish, do you want to do anything with the migrations?

review: Approve
Revision history for this message
Vish Ishaya (vishvananda) wrote :

no, it would only be for people who are upgrading from d4, earlier than that the host wasn't set. I don't feel it is really necessary.

Revision history for this message
Devin Carlen (devcamcar) wrote :

Sounds good, will approve.

Revision history for this message
Trey Morris (tr3buchet) wrote :

gah i gotta pay closer attention.. So networks have hosts, and fixed_ips have networks, floating_ips are associated with fixed_ips. Couldn't we just get to the host a floating_ip is associated with.

floating_ip['fixed_ip']['network']['host']
or
if ha
floating_ip['fixed_ip']['instance']['host']

I'm confused.

Revision history for this message
Vish Ishaya (vishvananda) wrote :

Yes that was my first approach, but it required changing linked tables in the db as well, so I figured go for the smaller change for diablo bug fixing. I you feel like the other change is more accurate, feel free to prop it into essex, perhaps with a drop column host in floating ips.

Vish

 On Sep 16, 2011, at 3:32 PM, Trey Morris wrote:

> gah i gotta pay closer attention.. So networks have hosts, and fixed_ips have networks, floating_ips are associated with fixed_ips. Couldn't we just get to the host a floating_ip is associated with.
>
> floating_ip['fixed_ip']['network']['host']
> or
> if ha
> floating_ip['fixed_ip']['instance']['host']
>
> I'm confused.
> --
> https://code.launchpad.net/~vishvananda/nova/fix-floating-reboot/+merge/75279
> You are the owner of lp:~vishvananda/nova/fix-floating-reboot.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.