OpenStack Compute (nova)

Merge lp://qastaging/~vishvananda/nova/lp851157 into lp://qastaging/~hudson-openstack/nova/trunk

lp851157
Merge into trunk

Proposed by Vish Ishaya on 2011-09-15

Status:

Merged

Approved by:

Dan Prince on 2011-09-16

Approved revision:

1542

Merged at revision:

1578

Proposed branch:

lp://qastaging/~vishvananda/nova/lp851157

Merge into:

lp://qastaging/~hudson-openstack/nova/trunk

Diff against target:

11 lines (+1/-0)

1 file modified

nova/virt/libvirt/connection.py (+1/-0)

To merge this branch:

bzr merge lp://qastaging/~vishvananda/nova/lp851157

Medium

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Dan Prince (community)		Approve on 2011-09-16
Devin Carlen (community)	2011-09-15	Approve on 2011-09-15
Review via email: mp+75608@code.qastaging.launchpad.net

Description of the change

Removes the on-disk internal libvirt snapshot after it has been uploaded to glance.

Revision history for this message

Devin Carlen (devcamcar) wrote on 2011-09-15:

lgtm

review: Approve

Revision history for this message

Dan Prince (dan-prince) wrote on 2011-09-16:

pydoc for virDomainSnapshot:

     | delete(self, flags)
     | Delete the snapshot.
     |
     | If @flags is 0, then just this snapshot is deleted, and changes from
     | this snapshot are automatically merged into children snapshots. If
     | flags is VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN, then this snapshot
     | and any children snapshots are deleted.

Looks good to me.

review: Approve