Merge lp://qastaging/~vishvananda/nova/volume-cleanup-2 into lp://qastaging/~hudson-openstack/nova/trunk

Proposed by Vish Ishaya
Status: Needs review
Proposed branch: lp://qastaging/~vishvananda/nova/volume-cleanup-2
Merge into: lp://qastaging/~hudson-openstack/nova/trunk
Prerequisite: lp://qastaging/~mcgrue/nova/volume-cleanup
Diff against target: 3176 lines (+1006/-933)
36 files modified
Authors (+1/-0)
bin/nova-manage (+2/-3)
doc/source/runnova/getting.started.rst (+0/-1)
nova/compute/api.py (+3/-2)
nova/compute/manager.py (+146/-82)
nova/compute/utils.py (+0/-29)
nova/db/api.py (+1/-35)
nova/db/sqlalchemy/api.py (+5/-55)
nova/db/sqlalchemy/migrate_repo/versions/048_kill_export_devices.py (+51/-0)
nova/db/sqlalchemy/migrate_repo/versions/049_add_connection_info_to_block_device_mapping.py (+35/-0)
nova/db/sqlalchemy/models.py (+2/-15)
nova/exception.py (+4/-4)
nova/rpc/common.py (+4/-5)
nova/tests/api/ec2/test_cloud.py (+11/-10)
nova/tests/fake_flags.py (+0/-4)
nova/tests/integrated/test_volumes.py (+5/-5)
nova/tests/scheduler/test_scheduler.py (+3/-2)
nova/tests/test_compute.py (+95/-227)
nova/tests/test_libvirt.py (+127/-13)
nova/tests/test_virt_drivers.py (+5/-3)
nova/tests/test_volume.py (+2/-80)
nova/tests/test_xenapi.py (+20/-4)
nova/virt/driver.py (+6/-5)
nova/virt/fake.py (+19/-4)
nova/virt/hyperv.py (+4/-3)
nova/virt/libvirt.xml.template (+7/-15)
nova/virt/libvirt/connection.py (+91/-48)
nova/virt/libvirt/volume.py (+149/-0)
nova/virt/vmwareapi_conn.py (+4/-3)
nova/virt/xenapi/volume_utils.py (+8/-7)
nova/virt/xenapi/volumeops.py (+7/-4)
nova/virt/xenapi_conn.py (+10/-7)
nova/volume/api.py (+40/-4)
nova/volume/driver.py (+110/-221)
nova/volume/manager.py (+29/-30)
nova/volume/san.py (+0/-3)
To merge this branch: bzr merge lp://qastaging/~vishvananda/nova/volume-cleanup-2
Reviewer Review Type Date Requested Status
Thierry Carrez (community) ffe Abstain
Christopher MacGown (community) Needs Resubmitting
Review via email: mp+72270@code.qastaging.launchpad.net

Description of the change

This is an initial proposal just to get on the radar, and potentially start collecting feedback. I'm trying to decouple the interactions between compute and volume and allow new drivers to be written for each hypervisor. This code is not expected to run nor pass tests yet. The goal is to allow volumes to be used generically and easily support other services like Lunr and VSA. I'm cleaning it up still, but here is the curent progress:

 * Removes discover and undiscover volume
 * Implements a generic driver model for libvirt volume attachment (something can be done for xen as well, but right now it only supports iscsi)
 * Adds initialize_connection and terminate_connection which prepare a volume to be attached to from another machine

To post a comment you must log in.
Revision history for this message
Thierry Carrez (ttx) wrote :

This should wait for Essex, based on the meeting we had on 2011-08-23

review: Disapprove
Revision history for this message
Thierry Carrez (ttx) :
review: Disapprove (ffe)
Revision history for this message
Christopher MacGown (0x44) wrote :

If this is FFE refused, we should put it back into WIP.

review: Needs Resubmitting
Revision history for this message
Thierry Carrez (ttx) wrote :

Essex is open

review: Abstain (ffe)

Unmerged revisions

1402. By Vish Ishaya

make it work when we are on the same host

1401. By Vish Ishaya

use tuples for login and logout

1400. By Vish Ishaya

renumber migrations

1399. By Vish Ishaya

merged trunk

1398. By Vish Ishaya

fix rescan and messed up permissions

1397. By Vish Ishaya

compare as string instead of converting to int

1396. By Vish Ishaya

fix integrated attach volume test

1395. By Vish Ishaya

fix scheduler test

1394. By Vish Ishaya

changes from volume api

1393. By Vish Ishaya

pull in changes from manager

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.