Merge lp://qastaging/~vivekys/nova/lp790174 into lp://qastaging/~hudson-openstack/nova/trunk

Proposed by vivek.ys
Status: Work in progress
Proposed branch: lp://qastaging/~vivekys/nova/lp790174
Merge into: lp://qastaging/~hudson-openstack/nova/trunk
Diff against target: 128 lines (+58/-7)
3 files modified
nova/tests/test_vmwareapi.py (+3/-3)
nova/virt/vmwareapi/fake.py (+3/-0)
nova/virt/vmwareapi/vmops.py (+52/-4)
To merge this branch: bzr merge lp://qastaging/~vivekys/nova/lp790174
Reviewer Review Type Date Requested Status
Todd Willey (community) Needs Fixing
Nova Core security contacts Pending
Sateesh Pending
Review via email: mp+63584@code.qastaging.launchpad.net

Description of the change

Added functionality for pause and resume of vmware hypervisor. In addition to this power state of the VM has been changed to reflect the actual state. That is when VM is paused, the power state pause & when it is suspended it is suspended.

To post a comment you must log in.
Revision history for this message
Todd Willey (xtoddx) wrote :

Extra newline on line 65. I think there should be more indents on 79, 80, 86, 107, 108, and 114. I don't have a stack to try this on, but it looks inline with what the vmware operations look like elsewhere. I've requested a review from the vmware lieutenant for better feedback and hopefully some testing.

review: Needs Fixing

Unmerged revisions

1154. By Vivek YS <email address hidden>

Added pause and resume support for vmware hypervisor.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.