Code review comment for lp://qastaging/~wibblymat/ubuntu/oneiric/ettercap/merge-debian-0.7.3-2.2

Revision history for this message
Daniel Holbach (dholbach) wrote :

Thanks a lot for your work. It seems to fail to build for me:

interfaces/gtk/libec_gtk.a(libec_gtk_a-ec_gtk_hosts.o): In function `gtkui_load_hosts':
/tmp/buildd/ettercap-0.7.3/src/interfaces/gtk/ec_gtk_hosts.c:80: undefined reference to `gtk_file_selection_new'
/tmp/buildd/ettercap-0.7.3/src/interfaces/gtk/ec_gtk_hosts.c:82: undefined reference to `gtk_dialog_get_type'
/tmp/buildd/ettercap-0.7.3/src/interfaces/gtk/ec_gtk_hosts.c:82: undefined reference to `g_type_check_instance_cast'
/tmp/buildd/ettercap-0.7.3/src/interfaces/gtk/ec_gtk_hosts.c:82: undefined reference to `gtk_dialog_run'
/tmp/buildd/ettercap-0.7.3/src/interfaces/gtk/ec_gtk_hosts.c:91: undefined reference to `gtk_widget_destroy'
/tmp/buildd/ettercap-0.7.3/src/interfaces/gtk/ec_gtk_hosts.c:85: undefined reference to `gtk_widget_hide'
/tmp/buildd/ettercap-0.7.3/src/interfaces/gtk/ec_gtk_hosts.c:86: undefined reference to `gtk_file_selection_get_type'
/tmp/buildd/ettercap-0.7.3/src/interfaces/gtk/ec_gtk_hosts.c:86: undefined reference to `g_type_check_instance_cast'
/tmp/buildd/ettercap-0.7.3/src/interfaces/gtk/ec_gtk_hosts.c:86: undefined reference to `gtk_file_selection_get_filename'
/tmp/buildd/ettercap-0.7.3/src/interfaces/gtk/ec_gtk_hosts.c:91: undefined reference to `gtk_widget_destroy'
interfaces/gtk/libec_gtk.a(libec_gtk_a-ec_gtk_hosts.o): In function `gtkui_hosts_detach':
/tmp/buildd/ettercap-0.7.3/src/interfaces/gtk/ec_gtk_hosts.c:256: undefined reference to `gtk_window_present'
collect2: ld returned 1 exit status
make[3]: *** [ettercap] Error 1
make[3]: Leaving directory `/tmp/buildd/ettercap-0.7.3/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/tmp/buildd/ettercap-0.7.3/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/tmp/buildd/ettercap-0.7.3'
make: *** [build-stamp] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
E: Failed autobuilding of package
I: unmounting /var/cache/pbuilder/ccache filesystem
I: unmounting dev/pts filesystem
I: unmounting proc filesystem
I: cleaning the build env

Maybe the newer version in Debian builds after a merge?

review: Needs Fixing

« Back to merge proposal