The Sound Menu

Merge lp://qastaging/~xavi-garcia-mena/indicator-sound/bug-pressing-cancel-accounts-service into lp://qastaging/indicator-sound/15.10

  1. bug-pressing-cancel-accounts-service
  2. Merge into trunk.15.10
Proposed by Xavi Garcia
Status: Merged
Approved by: Charles Kerr
Approved revision: 538
Merged at revision: 538
Proposed branch: lp://qastaging/~xavi-garcia-mena/indicator-sound/bug-pressing-cancel-accounts-service
Merge into: lp://qastaging/indicator-sound/15.10
Diff against target: 37 lines (+14/-0)
2 files modified
src/service.vala (+4/-0)
src/volume-warning.vala (+10/-0)
To merge this branch: bzr merge lp://qastaging/~xavi-garcia-mena/indicator-sound/bug-pressing-cancel-accounts-service
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+291985@code.qastaging.launchpad.net

Commit message

This branch adds a new signal in volumeWarning to set the warning level volume after pressing cancel.
We are setting the warning level before pressing cancel, which is alright, but sometimes we have issues with the value set to the accounts service that steps on the warning level.

Description of the change

This branch adds a new signal in volumeWarning to set the warning level volume after pressing cancel.
We are setting the warning level before pressing cancel, which is alright, but sometimes we have issues with the value set to the accounts service that steps on the warning level.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:538
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/322/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-amd64-ci/97
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-armhf-ci/98
        deb: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-armhf-ci/98/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/322/rebuild

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

The patch is fine, approved.

Just thinking out loud, the existing codebase is a little clumsy in how it treats volumes as sometimes a PulseAudio.Volume level, and sometimes a percentage of norm, etc. It might be better to have an actual Volume class that understands these things s.t. we have a consistent volume and don't repeat the conversion utils.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches