Code review comment for lp://qastaging/~xavi-garcia-mena/indicator-sound/bug-pressing-cancel-accounts-service

Revision history for this message
Charles Kerr (charlesk) wrote :

The patch is fine, approved.

Just thinking out loud, the existing codebase is a little clumsy in how it treats volumes as sometimes a PulseAudio.Volume level, and sometimes a percentage of norm, etc. It might be better to have an actual Volume class that understands these things s.t. we have a consistent volume and don't repeat the conversion utils.

review: Approve

« Back to merge proposal