Code review comment for lp://qastaging/~xavi-garcia-mena/indicator-sound/last-running-player-accounts-service

Revision history for this message
Xavi Garcia (xavi-garcia-mena) wrote :

Thanks for the review, Charles!

I assumed the existing code had passed already a code review in deep and did not refactored it. Big mistake.

I've fixed almost everything you commented. I think there's only one point remaining... please take a look at the inline comments.

« Back to merge proposal