Code review comment for lp://qastaging/~xfactor973/charms/trusty/ceph/erasure_actions

Revision history for this message
James Page (james-page) wrote :

These tests are not executed under tox:

======================================================================
ERROR: unit_tests.test_ceph_broker.test_process_requests_create_pool_exists
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/usr/lib/python2.7/dist-packages/mock/mock.py", line 1297, in patched
    arg = patching.__enter__()
  File "/usr/lib/python2.7/dist-packages/mock/mock.py", line 1369, in __enter__
    original, local = self.get_original()
  File "/usr/lib/python2.7/dist-packages/mock/mock.py", line 1343, in get_original
    "%s does not have the attribute %r" % (target, name)
AttributeError: <module 'ceph_broker' from 'hooks/ceph_broker.pyc'> does not have the attribute 'create_pool'

======================================================================
ERROR: unit_tests.test_ceph_broker.test_process_requests_create_pool_rid
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/usr/lib/python2.7/dist-packages/mock/mock.py", line 1297, in patched
    arg = patching.__enter__()
  File "/usr/lib/python2.7/dist-packages/mock/mock.py", line 1369, in __enter__
    original, local = self.get_original()
  File "/usr/lib/python2.7/dist-packages/mock/mock.py", line 1343, in get_original
    "%s does not have the attribute %r" % (target, name)
AttributeError: <module 'ceph_broker' from 'hooks/ceph_broker.pyc'> does not have the attribute 'create_pool'

======================================================================
ERROR: unit_tests.test_ceph_broker.test_process_requests_invalid_api_rid
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/usr/lib/python2.7/dist-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
TypeError: test_process_requests_invalid_api_rid() takes exactly 2 arguments (1 given)

----------------------------------------------------------------------

review: Needs Fixing

« Back to merge proposal