Code review comment for lp://qastaging/~xianghui/charm-helpers/lp1385162

Revision history for this message
Edward Hope-Morley (hopem) wrote :

Getting some unit test failures:

$ make test
Starting tests...
nose.plugins.cover: ERROR: Coverage not available: unable to import coverage module
.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................{u'DISTRIB_CODENAME': u'saucy', u'DISTRIB_RELEASE': u'13.10', u'DISTRIB_ID': u'Ubuntu', u'DISTRIB_DESCRIPTION': u'"Ubuntu Saucy Salamander (development branch)"'}
{u'DISTRIB_CODENAME': u'saucy', u'DISTRIB_RELEASE': u'13.10', u'DISTRIB_ID': u'Ubuntu', u'DISTRIB_DESCRIPTION': u'"Ubuntu Saucy Salamander (development branch)"'}
{u'DISTRIB_CODENAME': u'saucy', u'DISTRIB_RELEASE': u'13.10', u'DISTRIB_ID': u'Ubuntu', u'DISTRIB_DESCRIPTION': u'"Ubuntu Saucy Salamander (development branch)"'}
{u'DISTRIB_CODENAME': u'saucy', u'DISTRIB_RELEASE': u'13.10', u'DISTRIB_ID': u'Ubuntu', u'DISTRIB_DESCRIPTION': u'"Ubuntu Saucy Salamander (development branch)"'}
...............................................................................................................................................E: Could not open lock file /var/lib/dpkg/lock - open (13: Permission denied)
E: Unable to lock the administration directory (/var/lib/dpkg/), are you root?
F.E...................................
======================================================================
ERROR: Failure: OSError ([Errno 2] No such file or directory)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/nose/loader.py", line 411, in loadTestsFromName
    addr.filename, addr.module)
  File "/usr/lib/python2.7/dist-packages/nose/importer.py", line 47, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/usr/lib/python2.7/dist-packages/nose/importer.py", line 94, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/home/gizmo/Documents/reviews/charm-helpers/lp1385162/tests/fetch/test_giturl.py", line 8, in <module>
    from charmhelpers.fetch import (
  File "/home/gizmo/Documents/reviews/charm-helpers/lp1385162/charmhelpers/fetch/giturl.py", line 12, in <module>
    apt_install("python-git")
  File "/home/gizmo/Documents/reviews/charm-helpers/lp1385162/charmhelpers/fetch/__init__.py", line 157, in apt_install
    options))
  File "/home/gizmo/Documents/reviews/charm-helpers/lp1385162/charmhelpers/core/hookenv.py", line 67, in log
    subprocess.call(command)
  File "/usr/lib/python2.7/subprocess.py", line 522, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

======================================================================
FAIL: tests.fetch.test_fetch.PluginTest.test_plugins_are_valid
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/mock.py", line 1210, in patched
    return func(*args, **keywargs)
  File "/home/gizmo/Documents/reviews/charm-helpers/lp1385162/tests/fetch/test_fetch.py", line 407, in test_plugins_are_valid
    self.assertEqual(len(fetch.FETCH_HANDLERS), len(plugins))
  File "/usr/lib/python2.7/dist-packages/testtools/testcase.py", line 321, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/usr/lib/python2.7/dist-packages/testtools/testcase.py", line 406, in assertThat
    raise mismatch_error
MismatchError: 3 != 2

----------------------------------------------------------------------
Ran 758 tests in 5.971s

FAILED (errors=1, failures=1)
make: *** [test] Error 1

review: Needs Fixing

« Back to merge proposal