Merge lp://qastaging/~xtoddx/nova/glance-venv into lp://qastaging/~hudson-openstack/nova/trunk
Proposed by
Todd Willey
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://qastaging/~xtoddx/nova/glance-venv |
| Merge into: | lp://qastaging/~hudson-openstack/nova/trunk |
| Diff against target: |
203 lines (+91/-79) 1 file modified
tools/install_venv.py (+91/-79) |
| To merge this branch: | bzr merge lp://qastaging/~xtoddx/nova/glance-venv |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Soren Hansen (community) | Needs Resubmitting | ||
| Jay Pipes (community) | Disapprove | ||
|
Review via email:
|
|||
Description of the change
Add glance to venv. I'm doing this as a .pth file similar to how we do it for nova. I think we should have all openstack components as .pth files and not as pip packages in case we're working on developing a feature that touches multiple packages.
lp:~citrix-openstack has a branch (lp:~citrix-openstack/nova/xenapi-glance-2) that adds glance to pip-requires instead. We should figure out which makes more sense and make sure we don't conflict.
To post a comment you must log in.
Unmerged revisions
- 575. By Todd Willey
-
pep8 on tools/nova_venv.py, even though it isn't checked by hudson.
- 574. By Todd Willey
-
clean up file writes, and use two-levels of dirname calls for right path.
- 573. By Todd Willey
-
Add glance to venv.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I don't think we should treat Glance differently than any other dependency, so I'm going to vote no on this one...plus, there's a bug that I'm currently addressing this issue in: https:/