Code review comment for lp://qastaging/~yamahata/glance/lp802893

Revision history for this message
Isaku Yamahata (yamahata) wrote :

On Wed, Jun 29, 2011 at 09:49:27PM -0000, Jay Pipes wrote:
> On Wed, Jun 29, 2011 at 4:43 PM, Vish Ishaya <email address hidden> wrote:
> > Is there any reason you can't just do a json.dumps and save it as a text blob, then use json.loads on the other end? ??I don't see why complex metadata needs to be split into a bunch of separate properties.
>
> That's a perfectly reasonable solution.
>
> Of course, it would preclude any ability to filter on such things. If
> I wanted to find all images where delete_on_terminate was set, the
> query would be a beast and issue a full table scan over
> image_properties, since there would be no ability to do an equality
> search.
>
> So, long term, I think if it's information we want to query, we should
> look to a more robust method of storing the pieces of information.

If there is no major objection, I'd like to go for the middleware
idea that Jay suggested.

--
yamahata

« Back to merge proposal