OpenStack Compute (nova)

Merge lp://qastaging/~yamahata/nova/lp762551 into lp://qastaging/~hudson-openstack/nova/trunk

lp762551
Merge into trunk

Proposed by Isaku Yamahata on 2011-04-17

Status:

Rejected

Rejected by:

Vish Ishaya on 2011-05-11

Proposed branch:

lp://qastaging/~yamahata/nova/lp762551

Merge into:

lp://qastaging/~hudson-openstack/nova/trunk

Diff against target:

30 lines (+13/-0)

1 file modified

nova/twistd.py (+13/-0)

To merge this branch:

bzr merge lp://qastaging/~yamahata/nova/lp762551

Medium

Won't Fix

Link a bug report

Reviewer	Review Type	Date Requested	Status
Vish Ishaya (community)		2011-04-17	Disapprove on 2011-04-22
Review via email: mp+58033@code.qastaging.launchpad.net

Revision history for this message

termie (termie) wrote on 2011-04-20:

I'm not sure we want to continue working on nova-instancemonitor as it stands, I think we intend to, at the very least, port it to eventlet... I also didn't think anybody was currently actually using it... are you?

Revision history for this message

Isaku Yamahata (yamahata) wrote on 2011-04-21:

On Wed, Apr 20, 2011 at 11:22:23PM -0000, termie wrote:
> I'm not sure we want to continue working on nova-instancemonitor as it stands, I think we intend to, at the very least, port it to eventlet... I also didn't think anybody was currently actually using it... are you?

No I'm not. I tried to run all the daemons, and hit the bug.
It seemed an easy bug, so I sent the patch without knowing
such a situation.

Anyway I'm quite fine with leaving it as is.

thanks,
--
yamahata

Revision history for this message

Vish Ishaya (vishvananda) wrote on 2011-04-22:

Yes lets overhaul this later. It doesn't work currently so fixing the flags seems moot.

review: Disapprove