Code review comment for lp://qastaging/~zsombi/ubuntu-ui-toolkit/paleette2

Revision history for this message
Cris Dywan (kalikiana) wrote :

> Summarizing of what we discussed, we need a code which selects the color from
> the proper valueset, however that must be based on enabled and "selected"
> notion rather than enabled and activeFocus. The selected valueset should only
> be used if the item has the ability to do that. And we need to decide what
> will be the criteria. I'd rather do this in a separate MR than in this one.
> But we can agree on that in the standup.

Yeah, as agreed we can iterate it later; enabled is now handled and that's enough for what we need here.
Things are looking a lot better with all the fixes!

review: Approve

« Back to merge proposal