lp://qastaging/~zyga/checkbox/fix-1298166

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://qastaging/checkbox at revision 2843

Daniel Manrique (community): Approve on 2014-03-28

Diff: 192 lines (+24/-25)

9 files modified

checkbox-ng/checkbox_ng/commands/cli.py (+2/-4)
checkbox-ng/checkbox_ng/commands/sru.py (+1/-2)
plainbox/plainbox/impl/commands/analyze.py (+6/-5)
plainbox/plainbox/impl/commands/checkbox.py (+2/-1)
plainbox/plainbox/impl/commands/dev.py (+3/-3)
plainbox/plainbox/impl/commands/run.py (+2/-3)
plainbox/plainbox/impl/commands/script.py (+1/-2)
plainbox/plainbox/impl/commands/special.py (+5/-4)
plainbox/plainbox/impl/test_box.py (+2/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1298166: Some checkbox_ng commands don't use the PlainboxConfig objects when running jobs

Critical

Fix Released

Link a bug report

Related blueprints

2834. By Zygmunt Krynicki on 2014-03-27

plainbox,checkbox: pass config to each call to run_job()

This patch ensures that JobRunner.run_job() is always called with two
arguments. Calls without the second, optional, configuration object
cannot supply missing environment variables to jobs that need them,
leading to hard to understand bugs.

Fixes: https://bugs.launchpad.net/checkbox/+bug/1298166

2833. By Zygmunt Krynicki on 2014-03-27

plainbox,checkbox: make CheckBoxInvocationMixIn pass config object around

This patch sets the stage for the next patch which will rely on having
the configuration object available in several commands. To make that
possible the generic invocation mix-in is amended to require two arguments.

This puts code all around the tree and again requires locks-step update
of checkbox and plainbox.

Signed-off-by: Zygmunt Krynicki <email address hidden>

2832. By Daniel Manrique on 2014-03-27

"A fix so the network script doesn't barf when there's no target, and addition of environ: variables to the multi_nic job.
 [r=zkrynicki][bug=][author=roadmr]"

2831. By Zygmunt Krynicki on 2014-03-26

"automatic merge by tarmac [r=roadmr][bug=1297928][author=zkrynicki]"

2830. By Zygmunt Krynicki on 2014-03-26

"automatic merge by tarmac [r=roadmr][bug=1297906][author=zkrynicki]"

2829. By Zygmunt Krynicki on 2014-03-26

"automatic merge by tarmac [r=roadmr][bug=1297895][author=zkrynicki]"

2828. By Zygmunt Krynicki on 2014-03-26

"automatic merge by tarmac [r=roadmr][bug=1297990][author=zkrynicki]"

2827. By Zygmunt Krynicki on 2014-03-26

"automatic merge by tarmac [r=roadmr][bug=][author=zkrynicki]"

2826. By Launchpad Translations on behalf of checkbox-dev on 2014-03-26

Launchpad automatic translations update.

2825. By Zygmunt Krynicki on 2014-03-25

"automatic merge by tarmac [r=bladernr][bug=1297337][author=zkrynicki]"