Merge lp://qastaging/~zyga/checkbox/fix-1298166 into lp://qastaging/checkbox
Proposed by
Zygmunt Krynicki
| Status: | Merged |
|---|---|
| Approved by: | Daniel Manrique |
| Approved revision: | 2834 |
| Merged at revision: | 2843 |
| Proposed branch: | lp://qastaging/~zyga/checkbox/fix-1298166 |
| Merge into: | lp://qastaging/checkbox |
| Diff against target: |
192 lines (+24/-25) 9 files modified
checkbox-ng/checkbox_ng/commands/cli.py (+2/-4) checkbox-ng/checkbox_ng/commands/sru.py (+1/-2) plainbox/plainbox/impl/commands/analyze.py (+6/-5) plainbox/plainbox/impl/commands/checkbox.py (+2/-1) plainbox/plainbox/impl/commands/dev.py (+3/-3) plainbox/plainbox/impl/commands/run.py (+2/-3) plainbox/plainbox/impl/commands/script.py (+1/-2) plainbox/plainbox/impl/commands/special.py (+5/-4) plainbox/plainbox/impl/test_box.py (+2/-1) |
| To merge this branch: | bzr merge lp://qastaging/~zyga/checkbox/fix-1298166 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel Manrique (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
730f8c9 plainbox,checkbox: make CheckBoxInvocat
b0a31ad plainbox,checkbox: pass config to each call to run_job()
To post a comment you must log in.
Revision history for this message
| Zygmunt Krynicki (zyga) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good. I wonder if it would make sense to make the second argument to run_job non-optional, if we'll always be passing the config object we may as well require it explicitly. If you think it's a good idea we can do it later as this fix is good as-is and is high priority.