lp://qastaging/~zyga/checkbox/fix-1299210

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://qastaging/checkbox at revision 2995

Daniel Manrique (community): Approve on 2014-05-13

Diff: 393 lines (+135/-91)

6 files modified

checkbox-ng/checkbox_ng/commands/cli.py (+15/-33)
plainbox/plainbox/abc.py (+33/-0)
plainbox/plainbox/impl/commands/run.py (+4/-21)
plainbox/plainbox/impl/commands/test_run.py (+9/-21)
plainbox/plainbox/impl/ctrl.py (+33/-0)
plainbox/plainbox/impl/runner.py (+41/-16)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1299210: auth warmup is not under the control of the execution controller

High

Fix Released

Link a bug report

Related blueprints

3001. By Zygmunt Krynicki on 2014-05-13

plainbox:runner: drop authenticate_warmup()

This method is now entirely replaced by IJobRunner.get_warm_up_sequence()

Signed-off-by: Zygmunt Krynicki <email address hidden>

3000. By Zygmunt Krynicki on 2014-05-13

plainbox:commands:run: remove RunInvocation._auth_warmup_needed()

This patch removes the now-obsolete _auth_warmup_needed() method.
The responsibility and internal knowledge of that method is now
present in execution controllers.

Signed-off-by: Zygmunt Krynicki <email address hidden>

2999. By Zygmunt Krynicki on 2014-05-13

checkbox-ng:commands:cli: remove CliInvocation._auth_warmup_needed()

This method is now obsolete and is no longer being called by the
authentication code.

Signed-off-by: Zygmunt Krynicki <email address hidden>

2998. By Zygmunt Krynicki on 2014-05-13

checkbox-ng:commands:cli: use get_warm_up_sequence

This patch replaces the authenticate_warmup function with the
new runner.get_warm_up_sequence() method. Failure of authentication
warm-up no longer prevents the tests from proceeding as the user may
still correct the situation on each subsequent prompt.

Signed-off-by: Zygmunt Krynicki <email address hidden>

2997. By Zygmunt Krynicki on 2014-05-13

checkbox-ng:commands:cli: refactor CliInvocation

This patch moves construction of JobRunner from _run_jobs() to the main
method. Subsequent patches require that the runner object is available
early in run().

Signed-off-by: Zygmunt Krynicki <email address hidden>

2996. By Zygmunt Krynicki on 2014-05-13

plainbox:commands:run: simplify tests related to auth warmup

Since now the results are deterministic (in the tested case) we don't
need to check for one of two possible results.

Signed-off-by: Zygmunt Krynicki <email address hidden>

2995. By Zygmunt Krynicki on 2014-05-13

plainbox:abc: add IJobRunner.get_warm_up_sequence()

Signed-off-by: Zygmunt Krynicki <email address hidden>

2994. By Zygmunt Krynicki on 2014-05-13

plainbox:commands:run: use runner.get_warm_up_sequence()

This patch uses the new execution-controller-aware method to do warm-up
authentication in the implementation of `plainbox run`.

Signed-off-by: Zygmunt Krynicki <email address hidden>

2993. By Zygmunt Krynicki on 2014-05-13

plainbox:runner: add JobRunner.get_warm_up_sequence()

This patch adds a method that returns a list of warm-up callable hint
methods that should be called before running any of the jobs specified
as argument.

Signed-off-by: Zygmunt Krynicki <email address hidden>

2992. By Zygmunt Krynicki on 2014-05-13

plainbox:runner: split off _get_ctrl_for_job() from _run_extcmd()

This patch splits off a method to get an execution controller suitable
for a specific job into its own method (away from _run_extcmd()) as
we need that fuctionality in an upcoming patch

Signed-off-by: Zygmunt Krynicki <email address hidden>