Checkbox

Merge lp://qastaging/~zyga/checkbox/fix-1299210 into lp://qastaging/checkbox

fix-1299210
Merge into trunk

Proposed by Zygmunt Krynicki on 2014-05-13

Status:

Merged

Approved by:

Daniel Manrique on 2014-05-13

Approved revision:

3001

Merged at revision:

2995

Proposed branch:

lp://qastaging/~zyga/checkbox/fix-1299210

Merge into:

lp://qastaging/checkbox

Diff against target:

393 lines (+135/-91)

6 files modified

checkbox-ng/checkbox_ng/commands/cli.py (+15/-33)
plainbox/plainbox/abc.py (+33/-0)
plainbox/plainbox/impl/commands/run.py (+4/-21)
plainbox/plainbox/impl/commands/test_run.py (+9/-21)
plainbox/plainbox/impl/ctrl.py (+33/-0)
plainbox/plainbox/impl/runner.py (+41/-16)

To merge this branch:

bzr merge lp://qastaging/~zyga/checkbox/fix-1299210

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Daniel Manrique (community)		2014-05-13	Approve on 2014-05-13
Review via email: mp+219316@code.qastaging.launchpad.net

Description of the change

3e1382d plainbox:ctrl: add CheckBoxExecutionController.get_warm_up_for_job
ac93d40 plainbox:abc: add IExecutionController.get_warm_up_for_job()
b8b9380 plainbox:ctrl: implement RootViaPTL1ExecutionController.get_warm_up_for_job
0f9b67b plainbox:runner: fix typo in comment
d0dad89 plainbox:runner: split off _get_ctrl_for_job() from _run_extcmd()
1437bb0 plainbox:runner: add JobRunner.get_warm_up_sequence()
536eceb plainbox:commands:run: use runner.get_warm_up_sequence()
ae60a9f plainbox:abc: add IJobRunner.get_warm_up_sequence()
bb587dc plainbox:commands:run: simplify tests related to auth warmup
87dde25 checkbox-ng:commands:cli: refactor CliInvocation
cae29ce checkbox-ng:commands:cli: use get_warm_up_sequence
02b129a checkbox-ng:commands:cli: remove CliInvocation._auth_warmup_needed()
3628855 plainbox:commands:run: remove RunInvocation._auth_warmup_needed()
4d02c62 plainbox:runner: drop authenticate_warmup()

Revision history for this message

Daniel Manrique (roadmr) wrote on 2014-05-13:

Looks good, I like the part where it will just continue asking for the password, we had a lot of trouble with checkbox in the past on that scenario :)

review: Approve