lp://qastaging/~zyga/checkbox/investigation

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp://qastaging/checkbox

Zygmunt Krynicki (community): Needs Resubmitting on 2014-12-09

Sylvain Pineau (community): Approve on 2014-12-09

Diff: 509 lines (+187/-61)

10 files modified

plainbox/docs/manpages/plainbox.rst (+24/-0)
plainbox/plainbox/i18n.py (+70/-32)
plainbox/plainbox/impl/clitools.py (+21/-2)
plainbox/plainbox/impl/commands/cmd_session.py (+3/-0)
plainbox/plainbox/impl/commands/inv_session.py (+4/-1)
plainbox/plainbox/impl/session/resume.py (+4/-4)
plainbox/plainbox/impl/session/storage.py (+37/-11)
plainbox/plainbox/impl/session/test_storage.py (+5/-5)
plainbox/plainbox/impl/unit/testplan.py (+1/-1)
plainbox/plainbox/provider_manager.py (+18/-5)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

3498. By Zygmunt Krynicki on 2014-12-09

plainbox:i18n: fix non-default domain lookups

This patch changes how plainbox.i18n.{bind,}textdomain() works. In the
past they would just proxy the calls to the original python gettext
module.

This works okay for anything not using our internal i18n APIs. If, however,
someone is using dgettext() with a domain that's not 'plainbox', it would
fail to load the translation catalog from a custom domain *and* a custom
locale directory at the same time.

This patch moves textdomain and bindtextdomain functions to be a method
of the ITranslator API. Inside the GettextTranslator we now use
bindtextdomain as hints and store the locale directory which is finally
used to instantiate the translation catalog. For compatibility, both
methods are still calling their equivalents from thet gettext module.

Signed-off-by: Zygmunt Krynicki <email address hidden>

3497. By Zygmunt Krynicki on 2014-12-09

plainbox:clitools: add support for early logging

This patch adds support for early logging. Early logging can be enabled
even before command line argument parsing is attempted. It is perfect
for debugging command line handling code itself.

The feature is enabled by setting environment variables. There are three
new variables: PLAINBOX_DEBUG, PLAINBOX_TRACE and PLAINBOX_LOG_LEVEL.
The details of their behavior are documented in the plainbox manual
page.

Signed-off-by: Zygmunt Krynicki <email address hidden>

3496. By Zygmunt Krynicki on 2014-12-09

plainbox:provider_manager: fail gracefully in InstallCommand.get_command_epilog()

Signed-off-by: Zygmunt Krynicki <email address hidden>

3495. By Zygmunt Krynicki on 2014-12-09

plainbox:provider_manager: fix PEP-8 issue

Signed-off-by: Zygmunt Krynicki <email address hidden>

3494. By Zygmunt Krynicki on 2014-12-09

plainbox:provider_manager: add support for i18n in manage_py_extension

Signed-off-by: Zygmunt Krynicki <email address hidden>

3493. By Zygmunt Krynicki on 2014-12-09

plainbox:units:testplan: fix get_effective_category

This patch fixes TestPlan.get_effective_category() when no overrides
are being applied and the natural category is supposed to be returned.

Signed-off-by: Zygmunt Krynicki <email address hidden>

3492. By Zygmunt Krynicki on 2014-12-09

plainbox:commands: add 'session list --only-ids'

This patch adds a new argument to 'plainbox session list'. If invoked
with the --only-ids argument, the output is frendlier for scripting and
consists of session identifiers which are printed one per line.

Signed-off-by: Zygmunt Krynicki <email address hidden>

3491. By Zygmunt Krynicki on 2014-12-09

plainbox:session: fix typo in comment

Signed-off-by: Zygmunt Krynicki <email address hidden>

3490. By Zygmunt Krynicki on 2014-12-09

plainbox:session: fix FLAG_REWRITE_LOG_PATHNAMES_F

This patch fixes a embarrasing bug that gets triggered when session
resume is invoked with the rewrite-log-pathnames flag. The bug is a
result of later refactoring, which added binary flags in place of string
flags and set membership tests.

Signed-off-by: Zygmunt Krynicki <email address hidden>

3489. By Zygmunt Krynicki on 2014-12-09

plainbox:session: fix FLAG_IGNORE_JOB_CHECKSUMS_S

This patch fixes a embarrasing bug that gets triggered when session
resume is invoked with the ignore-job-checksums flag. The bug is a
result of later refactoring, which added binary flags in place of string
flags and set membership tests.

Signed-off-by: Zygmunt Krynicki <email address hidden>