Merge lp://qastaging/~zyga/checkbox/investigation into lp://qastaging/checkbox
| Status: | Rejected |
|---|---|
| Rejected by: | Zygmunt Krynicki |
| Proposed branch: | lp://qastaging/~zyga/checkbox/investigation |
| Merge into: | lp://qastaging/checkbox |
| Diff against target: |
509 lines (+187/-61) 10 files modified
plainbox/docs/manpages/plainbox.rst (+24/-0) plainbox/plainbox/i18n.py (+70/-32) plainbox/plainbox/impl/clitools.py (+21/-2) plainbox/plainbox/impl/commands/cmd_session.py (+3/-0) plainbox/plainbox/impl/commands/inv_session.py (+4/-1) plainbox/plainbox/impl/session/resume.py (+4/-4) plainbox/plainbox/impl/session/storage.py (+37/-11) plainbox/plainbox/impl/session/test_storage.py (+5/-5) plainbox/plainbox/impl/unit/testplan.py (+1/-1) plainbox/plainbox/provider_manager.py (+18/-5) |
| To merge this branch: | bzr merge lp://qastaging/~zyga/checkbox/investigation |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Zygmunt Krynicki (community) | Needs Resubmitting | ||
| Sylvain Pineau (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
b5ecf55 plainbox:session: respect PLAINBOX_
8229dbe plainbox:session: look for non-hidden .session directories
643a7b0 plainbox:session: fix FLAG_IGNORE_
9f7cfa9 plainbox:session: fix FLAG_REWRITE_
16fbbfd plainbox:session: fix typo in comment
a2476c7 plainbox:commands: add 'session list --only-ids'
| Daniel Manrique (roadmr) wrote | # |
| Zygmunt Krynicki (zyga) wrote | # |
| Zygmunt Krynicki (zyga) wrote | # |
Unmerged revisions
- 3498. By Zygmunt Krynicki
-
plainbox:i18n: fix non-default domain lookups
This patch changes how plainbox.
i18n.{bind, }textdomain( ) works. In the
past they would just proxy the calls to the original python gettext
module.This works okay for anything not using our internal i18n APIs. If, however,
someone is using dgettext() with a domain that's not 'plainbox', it would
fail to load the translation catalog from a custom domain *and* a custom
locale directory at the same time.This patch moves textdomain and bindtextdomain functions to be a method
of the ITranslator API. Inside the GettextTranslator we now use
bindtextdomain as hints and store the locale directory which is finally
used to instantiate the translation catalog. For compatibility, both
methods are still calling their equivalents from thet gettext module.Signed-off-by: Zygmunt Krynicki <email address hidden>
- 3497. By Zygmunt Krynicki
-
plainbox:clitools: add support for early logging
This patch adds support for early logging. Early logging can be enabled
even before command line argument parsing is attempted. It is perfect
for debugging command line handling code itself.The feature is enabled by setting environment variables. There are three
new variables: PLAINBOX_DEBUG, PLAINBOX_TRACE and PLAINBOX_LOG_LEVEL.
The details of their behavior are documented in the plainbox manual
page.Signed-off-by: Zygmunt Krynicki <email address hidden>
- 3496. By Zygmunt Krynicki
-
plainbox:
provider_ manager: fail gracefully in InstallCommand. get_command_ epilog( ) Signed-off-by: Zygmunt Krynicki <email address hidden>
- 3495. By Zygmunt Krynicki
-
plainbox:
provider_ manager: fix PEP-8 issue Signed-off-by: Zygmunt Krynicki <email address hidden>
- 3494. By Zygmunt Krynicki
-
plainbox:
provider_ manager: add support for i18n in manage_py_extension Signed-off-by: Zygmunt Krynicki <email address hidden>
- 3493. By Zygmunt Krynicki
-
plainbox:
units:testplan: fix get_effective_ category This patch fixes TestPlan.
get_effective_ category( ) when no overrides
are being applied and the natural category is supposed to be returned.Signed-off-by: Zygmunt Krynicki <email address hidden>
- 3492. By Zygmunt Krynicki
-
plainbox:commands: add 'session list --only-ids'
This patch adds a new argument to 'plainbox session list'. If invoked
with the --only-ids argument, the output is frendlier for scripting and
consists of session identifiers which are printed one per line.Signed-off-by: Zygmunt Krynicki <email address hidden>
- 3491. By Zygmunt Krynicki
-
plainbox:session: fix typo in comment
Signed-off-by: Zygmunt Krynicki <email address hidden>
- 3490. By Zygmunt Krynicki
-
plainbox:session: fix FLAG_REWRITE_
LOG_PATHNAMES_ F This patch fixes a embarrasing bug that gets triggered when session
resume is invoked with the rewrite-log-pathnames flag. The bug is a
result of later refactoring, which added binary flags in place of string
flags and set membership tests.Signed-off-by: Zygmunt Krynicki <email address hidden>
- 3489. By Zygmunt Krynicki
-
plainbox:session: fix FLAG_IGNORE_
JOB_CHECKSUMS_ S This patch fixes a embarrasing bug that gets triggered when session
resume is invoked with the ignore-job-checksums flag. The bug is a
result of later refactoring, which added binary flags in place of string
flags and set membership tests.Signed-off-by: Zygmunt Krynicki <email address hidden>
I wanted PLAINBOX_