lp://qastaging/~zyga/checkbox/session-peek-api

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://qastaging/checkbox at revision 2964

Daniel Manrique (community): Approve on 2014-04-30

Diff: 699 lines (+290/-175)

4 files modified

plainbox/plainbox/impl/session/__init__.py (+3/-1)
plainbox/plainbox/impl/session/resume.py (+251/-155)
plainbox/plainbox/impl/session/storage.py (+17/-0)
plainbox/plainbox/impl/session/test_resume.py (+19/-19)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1272762: load_checkpoint() doesn't handle missing 'session' file

High

Fix Released

Link a bug report

Related blueprints

2965. By Zygmunt Krynicki on 2014-04-30

plainbox:session: add SessionPeekHelper

This small class implements a peek(data) method and can peek at the
meta-data part of a session without having to restore a full session
(or handle any consistency issues the session may experience).

The new helper is added to objects importable from plainbox.impl.session

Signed-off-by: Zygmunt Krynicki <email address hidden>

2964. By Zygmunt Krynicki on 2014-04-30

plainbox:session: create EnvelopeUnpackMixIn

This small patch creates a mix-in class with the unpack_envelope() method
out of the initial part of SessionResumeHelper.resume() so that the
envelope unpacking code can be shared with the upcoming session peek
code.

Signed-off-by: Zygmunt Krynicki <email address hidden>

2963. By Zygmunt Krynicki on 2014-04-30

plainbox:session: refactor _restore_SessionState_metadata()

This patch changes the API of
SessionResumeHelper{1,2,3}_restore_SessionState_metadata() so that
the first argument is a metadata object rather than a session object.

In addition, each of the 1-2-3 format versions implementations of that
method are moved to separate mix-in class MetaDataHelper{1,2,3}MixIn.
The existing SessionResumeHelper{1,2,3} clasess are all made to inherit
from the mix in.

This effectively allows the mix-in classes to be used by another
piece of code that wants to resume the meta-data object alone, without
having to resume the whole session.

Existing tests are adjusted to pass 'session.metadata' instead
of 'session', to compensate for the change.

Signed-off-by: Zygmunt Krynicki <email address hidden>

2962. By Zygmunt Krynicki on 2014-04-30

plainbox:session: make SessionStorage.load_checkpoint() handle missing files

Previously the load_checkpoint() method would crash if the session file
does not exist. This can be the case before a first checkpoint is created.
In such cases we should simply treat that file as empty.

Signed-off-by: Zygmunt Krynicki <email address hidden>

2961. By Zygmunt Krynicki on 2014-04-30

plainbox:session: add SessionStorage.id

This new property serves as a simple identifier for sessions.
It is derived from the random session directory name.

Signed-off-by: Zygmunt Krynicki <email address hidden>

2960. By Daniel Manrique on 2014-04-30

"providers:checkbox: Remove nonexisting dependency from some after-suspend jobs.

    These jobs were renamed and their names are variable, so we can't
    express them in another job's depends: as that doesn't support
    wildcards.

    The easiest workaround at this point is to remove them from the
    dependencies. THe consequence is that the affected jobs (after suspend)
    will run even if their before-suspend counterpart failed. This doesn't
    sound too critical though, as if they fail before suspend but pass after
    suspend it may warrant a closer look.
 [r=sylvain-pineau][bug=1314383][author=roadmr]"

2959. By Daniel Manrique on 2014-04-30

"4f8aace providers:certification-client: Update whitelists to add card switching and tests for sec
17061d0 providers:checkbox: Added manual card switching prompt test

This should complete the hybrid graphics test suite, a simple manual test prompts the user to switch to the second card (if present), and after a restart the same set of tests run on card 1 should run on card 2.

 [r=apulido][bug=][author=roadmr]"

2958. By dann frazier on 2014-04-29

"Rearchitect the qemu commandline generation to simplify adding additional architecture support. [r=roadmr][bug=][author=dannf]"

2957. By Launchpad Translations on behalf of checkbox-dev on 2014-04-29

Launchpad automatic translations update.

2956. By Po-Hsu Lin on 2014-04-28

"automatic merge by tarmac [r=zkrynicki][bug=1229631][author=cypressyew]"