Merge lp://qastaging/~zyga/checkbox/session-peek-api into lp://qastaging/checkbox
Proposed by
Zygmunt Krynicki
| Status: | Merged |
|---|---|
| Approved by: | Daniel Manrique |
| Approved revision: | 2965 |
| Merged at revision: | 2964 |
| Proposed branch: | lp://qastaging/~zyga/checkbox/session-peek-api |
| Merge into: | lp://qastaging/checkbox |
| Diff against target: |
699 lines (+290/-175) 4 files modified
plainbox/plainbox/impl/session/__init__.py (+3/-1) plainbox/plainbox/impl/session/resume.py (+251/-155) plainbox/plainbox/impl/session/storage.py (+17/-0) plainbox/plainbox/impl/session/test_resume.py (+19/-19) |
| To merge this branch: | bzr merge lp://qastaging/~zyga/checkbox/session-peek-api |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel Manrique (community) | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2014-04-30.
Description of the change
933a1ed plainbox:session: add SessionStorage.id
5897758 plainbox:session: make SessionStorage.
6e72202 plainbox:session: refactor _restore_
08a3e28 plainbox:session: create EnvelopeUnpackMixIn
f300476 plainbox:session: add SessionPeekHelper
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Very cool :) the refactoring part looks OK and the peek stuff is a clever use of session metadata (I guess as the code says, if we restored the session to look at the metadata it could possibly barf). THanks!