Merge lp://qastaging/~zyga/snapcraft/fix-1484596 into lp://qastaging/~snappy-dev/snapcraft/core
Proposed by
Zygmunt Krynicki
Status: | Merged |
---|---|
Approved by: | Sergio Schvezov |
Approved revision: | 217 |
Merged at revision: | 216 |
Proposed branch: | lp://qastaging/~zyga/snapcraft/fix-1484596 |
Merge into: | lp://qastaging/~snappy-dev/snapcraft/core |
Diff against target: |
257 lines (+2/-55) 2 files modified
integration-tests/units/jobs.pxu (+1/-54) integration-tests/units/testplans.pxu (+1/-1) |
To merge this branch: | bzr merge lp://qastaging/~zyga/snapcraft/fix-1484596 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sergio Schvezov | Approve | ||
Review via email: mp+272702@code.qastaging.launchpad.net |
Commit message
Make integration tests easier to write
Description of the change
This branch contains the follow-up for the improvement of the plainbox feature flags. With plainbox 0.23 [1] released, we can now take advantage of the simple flag [1] which makes each job, possibly, down three lines, instead of 5-6 we had to write before.
[1] http://
[2] http://
To post a comment you must log in.
The attempt to merge lp:~zyga/snapcraft/fix-1484596 into lp:snapcraft failed. Below is the output from the failed tests.
[1;31mThe project has gotten complex[0m.
Here's the list of units exceeding 10:
- snapcraft/cmds.py:
286:1: 'cmd' 13
name: # the name of the snap g/parts/ copy/install/ zzz 7/parts/ copy/install/ dst n/parts/ copy/install/ dir/dst ======= ======= ======= ===[ Analyzing Jobs ]====== ======= ======= ======= ==== ======= ======= ======= =[ Session Statistics ]====== ======= ======= ======= == ======= ======= ======[ Running Selected Jobs ]====== ======= ======= ======= = ------- ------- -----[ snapcraft/ normal/ no-yaml ]------ ------- ------- ------ canonical. snapcraft: :snapcraft/ normal/ no-yaml canonical. plainbox: :uncategorised
version: # the version of the snap
# The vendor for the snap (replace 'Vendor <email address hidden>')
vendor: Vendor <email address hidden>
summary: # 79 char long summary
description: # A longer description for the snap
icon: # A path to an icon for the package
cp --preserve=all -R zzz /tmp/tmpt5q9u6j
cp --preserve=all -R src /tmp/tmpy68neff
cp --preserve=all -R src /tmp/tmpjtly1d6
=======
=======
This session is about 0.00% complete
Estimated duration is 0.10 for automated jobs.
Estimated duration cannot be determined for manual jobs.
Size of the desired job list: 27
Size of the effective execution plan: 27
=======
--------------[ Running job 1 / 27. Estimated time left: unknown ]--------------
-------
ID: 2015.com.
Category: 2013.com.
....... ....... ....... ....... ....... Warning: unable to find "test_relexepath" in the path ....... ....... ....... ....... ....... ....... ....... ....... .... ------- ------- ------- ------- ------- ------- ------- ------- -------
.......
-------
Ran 102 tests in 2.738s
OK color=None, command= <plainbox. impl.commands. cmd_run. RunCommand object at 0x7ff0e61a1438>, debug_console= False, debug_interrupt =False, dont_suppress_ output= False, dry_run=False, exclude_ pattern_ list=[] , include_ pattern_ list=[] , log_level=None, non_interactive =False, output_ file=<_ io.BufferedWrit er name='/ tmp/tmp. 1vH2ytGhgO/ result. json'>, output_ format= 'json', output_options='', pdb=False, test_plan= '2015.com. canonical. snapcraft: :normal' , trace=[], transport=None, transport_ options= None, transport_ where=None, whitelist=[]) has crashed python3/ dist-packages/ plainbox/ impl/clitools. py", line 560, in dispatch_ and_catch_ exceptions command( ns) python3/ dist-packages/ plainbox/ impl/clitools. py", line 556, in dispatch_command invoked( ns) python3/ dist-packages/ plainbox/ impl/commands/ cmd_run. py", line 44, in invoked provider_ loader, self.config_loader, ns, ns.color).run() python3/ dist-packages/ plainbox/ impl/commands/ inv_run. py", line 356, in run normal_ sequence( ) python3/ dist-packages/ plainbox/ impl/commands/ inv_run. py", line 410, in do_normal_sequence run_all_ selected_ jobs() python3/ dist-packages/ plainbox/ impl/commands/ inv_run. py", line 740, in run_all_ selected_ jobs
CRITICAL plainbox.crashes: Executable 'plainbox' invoked with Namespace(
Traceback (most recent call last):
File "/usr/lib/
return self.dispatch_
File "/usr/lib/
return ns.command.
File "/usr/lib/
self.
File "/usr/lib/
return self.do_
File "/usr/lib/
self.
File "/usr/lib/
self.run_sin...