Code review comment for lp://qastaging/~3v1n0/compiz/ccp-core-options-save-fix

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Yep this is fine for now.

Dunno if your latest revision also does CompPlugin *p = CompPlugin::find (), but it would be a useful way of reducing a bit of clutter.

Implementation wise, I would have just done bool equal = o->value () != v; Its a bit clearer than having if (o && something else) o = NULL; if (o).

review: Approve

« Back to merge proposal