Merge lp://qastaging/~3v1n0/unity/super-tab-switcher-shortcut-interaction into lp://qastaging/unity

>Plus, some code improvements and fixed an issue that caused the shortcut hint to show when pressing Super and clicking over the BFB to show the dash.

Which issue?

Never mind ;)

173 +bool Controller::IsEnabled()
174 +{
175 + return enabled_;
176 +}
177 +
178 +void Controller::SetEnabled(bool enabled)
179 +{
180 + enabled_ = enabled;
181 +}
182 +

Why not nux::Property enabled? What do you think?

+ optionSetShowMinimizedWindowsNotify (boost::bind(&UnityScreen::optionChanged, this, _1, _2));

Remove the space, please :)

271 +
272 + ubus_manager_.RegisterInterest(UBUS_LAUNCHER_START_KEY_NAV,
273 + sigc::mem_fun(this, &UnityScreen::OnLauncherStartKeyNav));
274 +
275 + ubus_manager_.RegisterInterest(UBUS_LAUNCHER_END_KEY_NAV,
276 + sigc::mem_fun(this, &UnityScreen::OnLauncherEndKeyNav));
277 +
278 + ubus_manager_.RegisterInterest(UBUS_QUICKLIST_END_KEY_NAV,
279 + sigc::mem_fun(this, &UnityScreen::OnQuicklistEndKeyNav));

Fix the indentation...

Btw it works well.

> 173 +bool Controller::IsEnabled()
> 174 +{
> 175 + return enabled_;
> 176 +}
> 177 +
> 178 +void Controller::SetEnabled(bool enabled)
> 179 +{
> 180 + enabled_ = enabled;
> 181 +}
> 182 +
>
> Why not nux::Property enabled? What do you think?

Mh... I'd prefer using this way, but let me know what you prefer.

> + optionSetShowMinimizedWindowsNotify
> (boost::bind(&UnityScreen::optionChanged, this, _1, _2));
>
> Remove the space, please :)
>
> 271 +
> 272 + ubus_manager_.RegisterInterest(UBUS_LAUNCHER_START_KEY_NAV,
> 273 +
> sigc::mem_fun(this, &UnityScreen::OnLauncherStartKeyNav));
> 274 +
> 275 + ubus_manager_.RegisterInterest(UBUS_LAUNCHER_END_KEY_NAV,
> 276 +
> sigc::mem_fun(this, &UnityScreen::OnLauncherEndKeyNav));
> 277 +
> 278 + ubus_manager_.RegisterInterest(UBUS_QUICKLIST_END_KEY_NAV,
> 279 +
> sigc::mem_fun(this, &UnityScreen::OnQuicklistEndKeyNav));
>
> Fix the indentation...

Damned you! :D
This was an Easter egg for you! ^_^

> Btw it works well.

Nice.
Do you have any design input about how the interaction with the expo? (Should the overlay be hidden when using mouse to activate it?)

> > 173 +bool Controller::IsEnabled()
> > 174 +{
> > 175 + return enabled_;
> > 176 +}
> > 177 +
> > 178 +void Controller::SetEnabled(bool enabled)
> > 179 +{
> > 180 + enabled_ = enabled;
> > 181 +}
> > 182 +
> >
> > Why not nux::Property enabled? What do you think?
>
> Mh... I'd prefer using this way, but let me know what you prefer.
>

I prefer nux::Property, but let decide Tim ;)

> > + optionSetShowMinimizedWindowsNotify
> > (boost::bind(&UnityScreen::optionChanged, this, _1, _2));
> >
> > Remove the space, please :)
> >
> > 271 +
> > 272 + ubus_manager_.RegisterInterest(UBUS_LAUNCHER_START_KEY_NAV,
> > 273 +
> > sigc::mem_fun(this, &UnityScreen::OnLauncherStartKeyNav));
> > 274 +
> > 275 + ubus_manager_.RegisterInterest(UBUS_LAUNCHER_END_KEY_NAV,
> > 276 +
> > sigc::mem_fun(this, &UnityScreen::OnLauncherEndKeyNav));
> > 277 +
> > 278 + ubus_manager_.RegisterInterest(UBUS_QUICKLIST_END_KEY_NAV,
> > 279 +
> > sigc::mem_fun(this, &UnityScreen::OnQuicklistEndKeyNav));
> >
> > Fix the indentation...
>
> Damned you! :D
> This was an Easter egg for you! ^_^
>
> > Btw it works well.
>
> Nice.
> Do you have any design input about how the interaction with the expo? (Should
> the overlay be hidden when using mouse to activate it?)

No.

I wouldn't get too hung up on it. Your indentation is still off in a few places, but not blocking.

Perhaps this is worth writing an autopilot test for?

You would need to expose the shortcut controller :)

Well, I guess that the autopilot test could be included into the generic launcher switcher test...