Code review comment for lp://qastaging/~3v1n0/unity/super-tab-switcher-shortcut-interaction

Revision history for this message
Andrea Azzarone (azzar1) wrote :

173 +bool Controller::IsEnabled()
174 +{
175 + return enabled_;
176 +}
177 +
178 +void Controller::SetEnabled(bool enabled)
179 +{
180 + enabled_ = enabled;
181 +}
182 +

Why not nux::Property enabled? What do you think?

+ optionSetShowMinimizedWindowsNotify (boost::bind(&UnityScreen::optionChanged, this, _1, _2));

Remove the space, please :)

271 +
272 + ubus_manager_.RegisterInterest(UBUS_LAUNCHER_START_KEY_NAV,
273 + sigc::mem_fun(this, &UnityScreen::OnLauncherStartKeyNav));
274 +
275 + ubus_manager_.RegisterInterest(UBUS_LAUNCHER_END_KEY_NAV,
276 + sigc::mem_fun(this, &UnityScreen::OnLauncherEndKeyNav));
277 +
278 + ubus_manager_.RegisterInterest(UBUS_QUICKLIST_END_KEY_NAV,
279 + sigc::mem_fun(this, &UnityScreen::OnQuicklistEndKeyNav));

Fix the indentation...

Btw it works well.

review: Needs Fixing

« Back to merge proposal