HR - Timesheet Management

Merge lp://qastaging/~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone into lp://qastaging/~hr-core-editors/hr-timesheet/7.0

fix-hr_attendance_analysis-report-timezone
Merge into 7.0

Proposed by Lorenzo Battistini on 2014-05-29

Status:	Work in progress
Proposed branch:	lp://qastaging/~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone
Merge into:	lp://qastaging/~hr-core-editors/hr-timesheet/7.0
Diff against target:	71 lines (+28/-9) 1 file modified hr_attendance_analysis/wizard/print_calendar_report.py (+28/-9)
To merge this branch:	bzr merge lp://qastaging/~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Alex Comba - Agile BG (community)	2014-05-29	Disapprove on 2014-07-30
Pedro Manuel Baeza	2014-05-29	Needs Resubmitting on 2014-07-29
Review via email: mp+221374@code.qastaging.launchpad.net

Description of the change

[FIX] hr_attendance_analysis
using correct timezone to print the sign in/out time

lp://qastaging/~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone updated on 2014-05-29

69. By Lorenzo Battistini on 2014-05-29: [FIX] hour and minutes

Revision history for this message

Pedro Manuel Baeza (pedro.baeza) wrote on 2014-05-29:

Hi, Lorenzo,

I think your fix has a problem with times that after been converted to correct timezone change its date. For example: 29/05/2014 00:12 GMT+2 >> 28/05/2014 22:12 UTC.

Regards.

review: Needs Information (code review)

lp://qastaging/~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone updated on 2014-05-30

70. By Lorenzo Battistini on 2014-05-30: [FIX] problem with times that after been converted to correct timezone change its date.
For example: 29/05/2014 00:12 GMT+2 >> 28/05/2014 22:12 UTC

Revision history for this message

Lorenzo Battistini (elbati) wrote on 2014-05-30:

Pedro, right, thanks.

I added the conversion to UTC while searching for attendances within the current_date.
This way, if selected current_date is 29/05/2014 (for a user in GMT+2), the sign in at 28/05/2014 22:12 UTC will be included in current_date.
So, every datetime is always expressed in the timezone of the user.

Revision history for this message

Pedro Manuel Baeza (pedro.baeza) wrote on 2014-07-29:

This project is now hosted on https://github.com/OCA/hr-timesheet. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting

Revision history for this message

Alex Comba - Agile BG (tafaru) wrote on 2014-07-30:

Moved to https://github.com/OCA/hr-timesheet/pull/7
I prefer do not delete the proposal to keep all the associated comments that have been made.

review: Disapprove

Unmerged revisions

70. By Lorenzo Battistini on 2014-05-30: [FIX] problem with times that after been converted to correct timezone change its date.
For example: 29/05/2014 00:12 GMT+2 >> 28/05/2014 22:12 UTC
69. By Lorenzo Battistini on 2014-05-29: [FIX] hour and minutes
68. By Lorenzo Battistini on 2014-05-29: [FIX] hr_attendance_analysis
using correct timezone to print the sign in/out time