Code review comment for lp://qastaging/~azzar1/unity/fix-830801
Revision history for this message
| Sam Spilsbury (smspillaz) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
> StaticCairoText needs a huge refactor to support unit-tests. I can add a unit-test without slowing down the code using > an #ifdef TESTS_ENABLED but I don't like it too much.
I don't think "huge refactor" is right here.
Probably makes more sense to split StaticCairoText into an mvc type thing, and make the view an interface so that you can mock it out in the tests.
The only other thing I can think of is the requirement for GdkScreen * to get font settings since it reads them from x propeties, but I am pretty sure this can be mocked out.
Not going to block it on this though.