Merge lp://qastaging/~cerberus/nova/instance_admin_for_user into lp://qastaging/~hudson-openstack/nova/trunk

This seems really straight forward, the only questions I have are not really about the code:

1) We have a file "accounts.py" in the same directory which seems to cover a lot of the same thing with a different name. Should we get rid of the concept of 'accounts' for now? I know that there has been a naming battle between projects/accounts.

2) Does creating a project require you to be an admin of the project? Seems like a chicken/egg scenario, but it's been a while since I've looked at the auth code...maybe admin users aren't linked to a project but are just general administrators for the entire system? If you could impart some knowledge on me that would be helpful. :)

Crazy minor nitpicks:
 -Line 90: Remove blank line
 -Line 162: Do you need that import?
 -Line 339: Do you need that import?

1) I completely missed the accounts controller. I suspect we need that functionality the way it is as per Dragon's multi-tenant accounting work

2) I'm pretty sure an "admin" in the global sense can create a project and assign any nova admin as the project manager. As far as what's proper, I'm not actually sure.

I'll set about merging my change into the accounts controller and dropping the projects controller out.

setting to work in progress..

trey: you're getting a little jumpy. I already made the changes and flipped it back to needs review :-)

Oops, guess I missed that. I'm not seeing any of this in the history.. weird.

Looks good.
Just trying to understand, would be more accurate to say you're creating an instance for an account? Or are all accounts linked to users?

For the record, the branch is misnamed now. As per Brian's suggestion, I linked the instance create to an account. All instances have both a project_id and user_id field, yet user_ids are also part of projects. As such, I created the instance for the project/account instead of the user.

Sorry for the delay here, can you add a test to make sure if you're not a member of that account, you can't create instances for it? I looks like if you're an admin of any project you can create instances in any other project currently?

Hi Matt. The dist sched-4 merge went in and added the new CreateInstanceHelper class in the openstack api code. Would using that be a better option here?

Brian: Can do, and yes, as an admin, right now you can. I was hoping to punt whether or not that's a good idea to the auth system when it finally lands

Dan: Yes, absolutely. Just haven't had a time to come back to it, yet