Code review comment for lp://qastaging/~cerberus/nova/instance_admin_for_user

Revision history for this message
Brian Lamar (blamar) wrote :

This seems really straight forward, the only questions I have are not really about the code:

1) We have a file "accounts.py" in the same directory which seems to cover a lot of the same thing with a different name. Should we get rid of the concept of 'accounts' for now? I know that there has been a naming battle between projects/accounts.

2) Does creating a project require you to be an admin of the project? Seems like a chicken/egg scenario, but it's been a while since I've looked at the auth code...maybe admin users aren't linked to a project but are just general administrators for the entire system? If you could impart some knowledge on me that would be helpful. :)

Crazy minor nitpicks:
 -Line 90: Remove blank line
 -Line 162: Do you need that import?
 -Line 339: Do you need that import?

review: Needs Information

« Back to merge proposal