Merge lp://qastaging/~cerberus/nova/lp853573 into lp://qastaging/~hudson-openstack/nova/trunk
Proposed by
Matt Dietz
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~cerberus/nova/lp853573 |
| Merge into: | lp://qastaging/~hudson-openstack/nova/trunk |
| Diff against target: |
278 lines (+203/-0) 8 files modified
nova/api/openstack/contrib/instanceactions.py (+86/-0) nova/compute/api.py (+6/-0) nova/compute/manager.py (+6/-0) nova/tests/api/openstack/contrib/test_instance_actions.py (+92/-0) nova/tests/api/openstack/test_extensions.py (+1/-0) nova/virt/driver.py (+4/-0) nova/virt/xenapi/vmops.py (+4/-0) nova/virt/xenapi_conn.py (+4/-0) |
| To merge this branch: | bzr merge lp://qastaging/~cerberus/nova/lp853573 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sandy Walsh (community) | Needs Information | ||
|
Review via email:
|
|||
Description of the change
Fixes lp853573 for XenServer only
Implements an OS API extension that allows a user to power back on an instance that was shutdown through other means.
To post a comment you must log in.
Unmerged revisions
- 1593. By Matt Dietz
-
Failed the inane extension list test
- 1592. By Matt Dietz
-
Merge from trunk
- 1591. By Matt Dietz
-
Merge from remote
- 1590. By Matt Dietz
-
Power on action extension with passing unit tests
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Shouldn't HyperV be pass'ed as well?
+47, you're using routing_get(), but don't have any decorators for redirecting the call the child zones (hmm, actually, haven't tried /server/XXX/action or extensions with rerouting, so it could be a fun investigation). So, either it should use .get() or use the decorators.
That get_updated() call seems like a recipe for debugging down the road. I know I'll never remember to update that method on a bug fix. I know, not your problem.
Otherwise, lgtm