Code review comment for lp://qastaging/~cerberus/nova/lp853573

Revision history for this message
Sandy Walsh (sandy-walsh) wrote :

Shouldn't HyperV be pass'ed as well?

+47, you're using routing_get(), but don't have any decorators for redirecting the call the child zones (hmm, actually, haven't tried /server/XXX/action or extensions with rerouting, so it could be a fun investigation). So, either it should use .get() or use the decorators.

That get_updated() call seems like a recipe for debugging down the road. I know I'll never remember to update that method on a bug fix. I know, not your problem.

Otherwise, lgtm

review: Needs Fixing

« Back to merge proposal