Merge lp://qastaging/~dandrader/unity8/noDecorationInStagedMode into lp://qastaging/unity8
Proposed by
Daniel d'Andrada
Status: | Merged |
---|---|
Approved by: | Lukáš Tinkl |
Approved revision: | 2841 |
Merged at revision: | 2876 |
Proposed branch: | lp://qastaging/~dandrader/unity8/noDecorationInStagedMode |
Merge into: | lp://qastaging/unity8 |
Diff against target: |
69 lines (+36/-3) 2 files modified
qml/Stage/DecoratedWindow.qml (+2/-1) tests/qmltests/Stage/tst_TabletStage.qml (+34/-2) |
To merge this branch: | bzr merge lp://qastaging/~dandrader/unity8/noDecorationInStagedMode |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Unity8 CI Bot | continuous-integration | Approve | |
Lukáš Tinkl (community) | Approve | ||
Review via email:
|
Commit message
Really disable the window decoration when in staged mode
Instead of having it only fully translucent (but still catching input).
So that it doesn't eat mouse clicks and taps near the window's top edge
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable
* If you changed the UI, has there been a design review?
Not applicable
To post a comment you must log in.
opacity: root.hasDecoration ? Math.min(1, root.showDecora tion) : 0
visible: root.hasDecoration || opacity > 0
I don't get the "visible" expression, why you need both?