Merge lp://qastaging/~djfroofy/txaws/modernize-924459 into lp://qastaging/txaws
Proposed by
Drew Smathers
Status: | Merged |
---|---|
Approved by: | Duncan McGreggor |
Approved revision: | 146 |
Merged at revision: | 145 |
Proposed branch: | lp://qastaging/~djfroofy/txaws/modernize-924459 |
Merge into: | lp://qastaging/txaws |
Diff against target: |
670 lines (+459/-28) 5 files modified
txaws/client/_producers.py (+122/-0) txaws/client/base.py (+178/-13) txaws/client/tests/test_base.py (+116/-11) txaws/client/tests/test_ssl.py (+20/-4) txaws/testing/producers.py (+23/-0) |
To merge this branch: | bzr merge lp://qastaging/~djfroofy/txaws/modernize-924459 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Duncan McGreggor | Approve | ||
Review via email: mp+92404@code.qastaging.launchpad.net |
Description of the change
Need to care how much we care about compatibility since: (1) This requires Twisted >= 11.1.0 so far as I know and (2) Some public members on BaseQuery no longer exist since they are not applicable when using Agent.
To post a comment you must log in.
On Thu, Feb 9, 2012 at 10:23 PM, Drew Smathers <email address hidden> wrote: web.client. Agent" /bugs.launchpad .net/txaws/ +bug/924459 /code.launchpad .net/~djfroofy/ txaws/modernize -924459/ +merge/ 92404
> Drew Smathers has proposed merging lp:~djfroofy/txaws/modernize-924459 into lp:txaws.
>
> Requested reviews:
> Duncan McGreggor (oubiwann)
> Related bugs:
> Bug #924459 in txAWS: "Modernize txaws.client to use twisted.
> https:/
>
> For more details, see:
> https:/
>
> Need to care how much we care about compatibility since: (1) This requires Twisted >= 11.1.0 so far as I know and (2) Some public members on BaseQuery no longer exist since they are not applicable when using Agent.
I've taken a quick look at the latest code tonight, and first glance
is a happy one :-)
I've branched the code on my laptop so that I can review it on the
plane tomorrow, run the unit tests, etc.
I hope to have more for you soon.