Merge lp://qastaging/~dpigott/lava-master-image-scripts/deployment-improvements into lp://qastaging/lava-master-image-scripts

Proposed by Dave Pigott
Status: Merged
Merged at revision: 58
Proposed branch: lp://qastaging/~dpigott/lava-master-image-scripts/deployment-improvements
Merge into: lp://qastaging/lava-master-image-scripts
Diff against target: 237 lines (+78/-19)
11 files modified
README (+7/-1)
boards.d/beagle.conf (+1/-1)
boards.d/imx53.conf (+1/-1)
boards.d/origen.conf (+1/-1)
boards.d/panda.conf (+1/-1)
boards.d/snowball.conf (+1/-1)
boards.d/vexpress.conf (+1/-1)
contrib/lava-partition-disk (+57/-11)
contrib/preEnv.txt (+1/-0)
lava-create-master (+1/-1)
master-rootfs-extras/lib/lava/lava-master-init (+6/-0)
To merge this branch: bzr merge lp://qastaging/~dpigott/lava-master-image-scripts/deployment-improvements
Reviewer Review Type Date Requested Status
Michael Hudson-Doyle (community) Approve
Zygmunt Krynicki Pending
Review via email: mp+104539@code.qastaging.launchpad.net

Description of the change

Add patch to apply fix for panda streaming bug on first boot

Make reference to rootfs and hwpack only have to be set once

Changes to lava-partition-disk use board type to set number of partitions, and to add preEnv.txt to TI boards so that bootdelay is set

Update documentation on new lava-partition-disk

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Lots of changes, good stuff, two comments:

0) Bzr workflow is sucky verbose, meh

1) The fix for panda is wrong, the first boot will still experience all the issues that line prevents. After changing sysctl config reload it (I don't recall the command not but it's probably sysctl -p

2) Can we move the partition step to happen at first boot please? It should be easily doable now. I know it's a lot to ask for so this can go in (noting that 1) needs to be fixed).

Revision history for this message
Dave Pigott (dpigott) wrote :

1) Sort of - we always reboot before doing anything, so the fix gets loaded
2) Completely agree. It's doable and I shall do it. :)

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I think I agree with Zygmunt that having a sysctl -p would be a bit cleaner although it's not really necessary. Doing the partitioning at first boot would be awesome but that can be in another branch :-)

WRT the streaming errors, it feels like we're stepping around a kernel bug really. Have we talked to any kernel people about it?

Anyway, add sysctl -p and merge please!

review: Approve
Revision history for this message
Spring Zhang (qzhang) wrote :

134 +case $1 in
135 + beagle)
136 + PRE_ENV=Y
137 + SCHEME=2part;;
138 +
139 + imx53)
140 + SCHEME=3part;;
141 +
142 + origen)
143 + SCHEME=3part;;
144 +
145 + panda)
146 + PRE_ENV=Y
147 + SCHEME=2part;;
148 +
149 + snowball)
150 + SCHEME=2part;;
151 +
152 + vexpress)
153 + SCHEME=2part;;

You can use:
imx53|origen)
SCHEME=3part;;
snowball|vexpress)
SCHEME=2part;;
beagle|panda)
PRE_ENV=Y
SCHEME=2part;;

to decrease duplication.

Revision history for this message
Dave Pigott (dpigott) wrote :

Spring: I tend to not like doing that, because at some point we may well want to add some more board specific stuff and then we end up having to split them anyway.

57. By Dave Pigott

Add sysctl refresh after load

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches