Code review comment for lp://qastaging/~dpigott/lava-master-image-scripts/deployment-improvements

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I think I agree with Zygmunt that having a sysctl -p would be a bit cleaner although it's not really necessary. Doing the partitioning at first boot would be awesome but that can be in another branch :-)

WRT the streaming errors, it feels like we're stepping around a kernel bug really. Have we talked to any kernel people about it?

Anyway, add sysctl -p and merge please!

review: Approve

« Back to merge proposal