Code review comment for lp://qastaging/~dpigott/lava-master-image-scripts/deployment-improvements
Revision history for this message
| Zygmunt Krynicki (zyga) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
Lots of changes, good stuff, two comments:
0) Bzr workflow is sucky verbose, meh
1) The fix for panda is wrong, the first boot will still experience all the issues that line prevents. After changing sysctl config reload it (I don't recall the command not but it's probably sysctl -p
2) Can we move the partition step to happen at first boot please? It should be easily doable now. I know it's a lot to ask for so this can go in (noting that 1) needs to be fixed).