Merge lp://qastaging/~justin-fathomdb/nova/termie-bot into lp://qastaging/~hudson-openstack/nova/trunk
Proposed by
justinsb
Status: | Work in progress |
---|---|
Proposed branch: | lp://qastaging/~justin-fathomdb/nova/termie-bot |
Merge into: | lp://qastaging/~hudson-openstack/nova/trunk |
Diff against target: |
334 lines (+329/-0) 1 file modified
contrib/rules/do_checks.py (+329/-0) |
To merge this branch: | bzr merge lp://qastaging/~justin-fathomdb/nova/termie-bot |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Vish Ishaya (community) | Approve | ||
Brian Lamar (community) | Abstain | ||
termie (community) | Needs Fixing | ||
Nova Core security contacts | Pending | ||
Review via email:
|
Description of the change
Simple style-checker that can check some of our style rules, and is easy to extend
To post a comment you must log in.
Unmerged revisions
- 911. By justinsb
-
Made discovery of checkers Pythonic
- 910. By justinsb
-
Merged with trunk
- 909. By justinsb
-
Remove regex for finding docstrings, replace with "my first parser" level code.
The regex was hanging on certain inputs, and also got confused by embedded quotes in docstrings
- 908. By justinsb
-
Fixed the checker to be checker-compliant
- 907. By justinsb
-
Code style cleanups
- 906. By justinsb
-
pep8 fixes
- 905. By justinsb
-
Check that multi-line docstrings end in a blank line
- 904. By justinsb
-
Fix pep8
- 903. By justinsb
-
Basic docstring checking
- 902. By justinsb
-
Added pep8, pylint, pretty output formats
I like the idea, but does this need to be shipped in the core code ? It looks a bit developer-only to me.