Code review comment for lp://qastaging/~justin-fathomdb/nova/termie-bot
Revision history for this message
| Jay Pipes (jaypipes) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
On Mon, Mar 28, 2011 at 12:50 PM, justinsb <email address hidden> wrote:
> Jay - I'm guessing termie would say it comes under this:
>
> "- thou shalt put two newlines twixt toplevel code (funcs, classes, etc)"
>
> But half the point of this is to get consistency by codifying these rules, as well as to let code reviewers focus on higher level concerns (like the pep8 checker does).
If that were what termie meant, I don't think he would have written
half the code in Nova to group top-level class constants together...
Do you REALLY want to see every module-level constant separated by 2 newlines?
-jay