Code review comment for lp://qastaging/~kamstrup/dee/filter-models-ng
Revision history for this message
| Mikkel Kamstrup Erlandsen (kamstrup) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
> I'm getting: `Warning: multiple "IDs" for constraint linkend: DeeFilter.` when
> generating the documentation, not sure what's the root cause of that, but it
> wasn't there in trunk.
I'll take a quick look; but it doesn't worry me too much right now as the docs themselves look fine. So I think we can land even if I don't find a fix right away.
> What's missing is regenerated vapi (we really need to hook that up into the
> build system properly) + no longer forcing Dee.Filter to be compact class.
Done
> One of the things I was never sure about is whether GI-langs are able to use
> functions that have in the C signature two function pointers and a single
> userdata + destroy (ie current dee_filter_new), but it doesn't seem likely.
This did cross my mind, and I thin you're right that it might now work. GDBus and other APIsdoes this as well though - but since we can easily expand the set of DeeFilters we distribute I am not too concerned about this.