Merge lp://qastaging/~kyrofa/snap-confine/create_user_data_directory into lp://qastaging/~snappy-dev/snap-confine/trunk
Proposed by
Kyle Fazzari
Status: | Merged |
---|---|
Merged at revision: | 90 |
Proposed branch: | lp://qastaging/~kyrofa/snap-confine/create_user_data_directory |
Merge into: | lp://qastaging/~snappy-dev/snap-confine/trunk |
Diff against target: |
454 lines (+328/-76) 2 files modified
src/main.c (+166/-76) tests/test_create_user_data (+162/-0) |
To merge this branch: | bzr merge lp://qastaging/~kyrofa/snap-confine/create_user_data_directory |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jamie Strandboge (community) | Approve | ||
Tyler Hicks (community) | Approve | ||
Review via email: mp+285360@code.qastaging.launchpad.net |
Commit message
Add creation of user data directory.
Description of the change
Both Snappy binaries and services are provided the $SNAP_USER_DATA environment variable. However, the job of actually creating that directory has until now been left up to the Snappy binary wrapper. Which means that the $SNAP_USER_DATA directory is created for binaries, but actually points to a non-existing directory for services, since nothing creates it (bug #1527612).
This MP attempts to bring the creation of the user data directory into the one thing that both binaries and services have in common: the launcher.
To post a comment you must log in.
Does this code run with more privileges than the services that it is working for?
If so, does something prevent the services from running at the same time?
If so, does something fix the directories' owner and group later?
Thanks