Code review comment for lp://qastaging/~mardy/gnome-control-center-signon/lib-unit-tests

Revision history for this message
David King (amigadave) wrote :

Looks good.

57 + if (priv->socket != NULL) {

Curly brace should be on the next line, by itself.

98 +GVariant *prepare_session_data_test(ApOAuthPlugin *self);
99 +GVariant *prepare_session_data_test(ApOAuthPlugin *self)

Spaces before brackets.

112 +extern GLib.Variant prepare_session_data_test(Ap.OAuthPlugin self);

Same again.

121 + Test.add_func ("/libaccount-plugin/client/load_plugin/0",
122 + client_load_plugin_0);
123 + Test.add_func ("/libaccount-plugin/client/load_application_plugin/0",
124 + client_load_application_plugin_0);

I do not like the "_0" naming here. As you assert on the plugin being null later, use "_null" instead, or some other more descriptive term such as "_not_found".

review: Needs Fixing

« Back to merge proposal