Merge lp://qastaging/~mcintire-evan/music-app/songs-fastscroll into lp://qastaging/music-app
Proposed by
Evan McIntire
Status: | Needs review |
---|---|
Proposed branch: | lp://qastaging/~mcintire-evan/music-app/songs-fastscroll |
Merge into: | lp://qastaging/music-app |
Diff against target: |
550 lines (+486/-1) 5 files modified
AUTHORS (+1/-0) app/components/FastScroll.qml (+316/-0) app/logic/FastScroll.js (+131/-0) app/ui/Songs.qml (+35/-1) debian/changelog (+3/-0) |
To merge this branch: | bzr merge lp://qastaging/~mcintire-evan/music-app/songs-fastscroll |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jenkins Bot | continuous-integration | Needs Fixing | |
Andrew Hayzen | Needs Fixing | ||
Victor Thompson | Needs Fixing | ||
Review via email:
|
Commit message
Add fastscroll to the song list
Description of the change
Add fastscroll to the song list
To post a comment you must log in.
Unmerged revisions
- 960. By Evan McIntire
-
Improve formatting of catagory headers
- 959. By Evan McIntire
-
Use lastest ListItem component; added DCH and AUTHORS entry
- 958. By Evan McIntire
-
Add FastScroll to the song list
The code for this looks good! I'm not sure however, that we'll want to merge this into the app. The Ubuntu SDK will be introducing scrollbars sometime soon and I think it'd be better to use that feature/component as we'll also want to use it in the Queue and other listviews.
Codewise, I do have 1 inline comment.